Auto merge of #3386 - matklad:warn-replace, r=alexcrichton
authorbors <bors@rust-lang.org>
Wed, 14 Dec 2016 01:19:37 +0000 (01:19 +0000)
committerbors <bors@rust-lang.org>
Wed, 14 Dec 2016 01:19:37 +0000 (01:19 +0000)
commit5e4a4e0f39f0dfac797f0273023dc51e2548b12d
treee3eae05fbff04d3baf5b201e369f14ef85d77264
parent020df9479bb09276a2fb2b5959f766f8281f5829
parentc7b3e5e95f03b769498f6c478fb28417e3c05c7b
Auto merge of #3386 - matklad:warn-replace, r=alexcrichton

Warn if replace is not actually used

closes #3324

I've added warnings to `resolve_dependencies` inside `cargo_compile.rs`. Adding them to `resolve_with_previous` does not work because that method is called several times.

Perhaps the best idea is to refactor resolve facade, such that we have only `ops::resolve`  and not `ops::resolve_ws`, `ops::resolve_with_previous` and `ops::resolve_dependencies`. IIRC, there were some bugs because of logic mismatch between `compile` and `metadata` commands.